search

jruby / activerecord-jdbc-adapter

JRuby's ActiveRecord adapter using JDBC.
BSD 2-Clause "Simplified" License
462 stars 385 forks source link

Rails 7.1 support #1146

Open mullermp opened 4 months ago

mullermp commented 4 months ago

Hello. The README suggests that the gem 71.x should support Rails 7.1 but I don't see any of these versions published to https://rubygems.org/gems/activerecord-jdbc-adapter or for the adapters.

mullermp commented 3 weeks ago

I'm currently doing something like:

  gem 'activerecord-jdbc-adapter', '~> 71.0',
      platform: :jruby,
      # this is not published for some reason
      git: 'https://github.com/jruby/activerecord-jdbc-adapter',
      glob: 'activerecord-jdbc-adapter.gemspec'
  gem 'activerecord-jdbcsqlite3-adapter', '~> 71.0',
      platform: :jruby,
      # this is not published for some reason
      git: 'https://github.com/jruby/activerecord-jdbc-adapter',
      glob: 'activerecord-jdbcsqlite3-adapter/activerecord-jdbcsqlite3-adapter.gemspec'

to pull the latest from github which essentially is 71.x support. 72.x support is still missing though.

headius commented 3 weeks ago

If my assessment is correct, 7.1 support is pretty solid for SQLite, nearly solid for MySQL, and still needs work for PostgreSQL. We know we need to get these out, plus 7.2 support, but we have been bogged down with lots of other issues the past few months.

@kares @enebo What's the status here?

enebo commented 3 weeks ago

@headius you have the right summary. we just need some time to get to this or some more help (which we got quite a bit a couple of months ago).

mullermp commented 3 weeks ago

How can I help? Do you have existing tests that would verify the completeness of those adapters when they are fully upgraded? What is the acceptance criteria to be ready for release?