The default values for arguments to Nomad.__init__ are read when the class is initialized (so when python reads __init__.py.
If one later want to change the values of the NOMAD_* env variables, these new values will get ignored because by then the defaults for arguments are already set.
This changes the commit to have a proper None default, and only read the current values of env variables when __init__() is called.
The default values for arguments to
Nomad.__init__
are read when the class is initialized (so when python reads__init__.py
. If one later want to change the values of theNOMAD_*
env variables, these new values will get ignored because by then the defaults for arguments are already set.This changes the commit to have a proper
None
default, and only read the current values of env variables when__init__()
is called.See https://medium.com/@nebiyuelias1/be-careful-when-using-default-arguments-in-python-fd92df94efee for why defining the default with a function call is prone to error.