jschaf / esup

ESUP - Emacs Start Up Profiler
401 stars 21 forks source link

Esup end of file error #22

Closed jschaf closed 8 years ago

jschaf commented 9 years ago

It errors out on https://github.com/dertuxmalwieder/My-Emacs-config/blob/master/.emacs

Reported by http://www.reddit.com/r/emacs/comments/32oufa/emacs_245_startup_time/

dertuxmalwieder commented 9 years ago

Additional info: It fails on 25.0.x, but still this shouldn't be the reason for this error.

jschaf commented 9 years ago

I'm not sure, https://github.com/jschaf/esup/issues/20 is the exact same problem on Emacs 25

dertuxmalwieder commented 9 years ago

Oh, OK. So it's not me. :-)

joedicastro commented 9 years ago

I have the same problem, 24.5.1 version here.

jschaf commented 9 years ago

Does it consistently fail? I'm having trouble reproducing it now.

dertuxmalwieder commented 9 years ago

It seems to work on Mac OS X. I reported the bug with the Windows build.

joedicastro commented 9 years ago

In my case, yes, fails always I use an Emacs 24.5.1 in Arch Linux with a 64bits kernel (3.19.3).

jschaf commented 9 years ago

I pushed a fix for whitespace. Can you all see if it resolved your issues?

If it does still error out please post the contents of *esup-log*. It probably won't appear by default, but it does exist.

joedicastro commented 9 years ago

I still have the problem, but this time I have also the diagnostic.

This is the *Messages* buffer in the esup child client:

For information about GNU Emacs and the GNU system, type C-h C-a.
Debug on Error enabled globally
esup: loading /home/joedicastro/.emacs.d/init.el
Followed link to /home/joedicastro/dotfiles/emacs/init.el
esup: loading /home/joedicastro/.emacs.d/elpa/diminish-20091203.1012/diminish.elc
esup-child-profile-sexp: End of file during parsing

The process alwasys stop (in my case) when the esup child process try to load the diminish.elc byte-compiled file of the diminish package. If I delete that .elc file all works fine again. I hope that helps you. To me seems a clear problem with the parser.

jschaf commented 9 years ago

Okay, it looks like a problem with .elc files. I haven't really tested parsing against them, so I'll take a look at that.

manuel-uberti commented 9 years ago

Any news on this one? Still not working for me on Emacs 25.0.50.1, it stops at diminish.elc

LOG: profiling sexp /home/manuel/.emacs.d/init.el:49 (require 'diminish)

LOG: loading /home/manuel/.emacs.d/elpa/diminish-20091203.1012/diminish.elc
jschaf commented 9 years ago

I have it on my todo list. Work has been kinda crazy. I'll take another look tonight.

On Mon, Aug 3, 2015 at 9:53 AM, Manuel Uberti notifications@github.com wrote:

Any news on this one? Still not working for me on Emacs 25.0.50.1, it stops at diminish.elc

LOG: profiling sexp /home/manuel/.emacs.d/init.el:49 (require 'diminish)

LOG: loading /home/manuel/.emacs.d/elpa/diminish-20091203.1012/diminish.elc

— Reply to this email directly or view it on GitHub https://github.com/jschaf/esup/issues/22#issuecomment-127243189.

immerrr commented 9 years ago

Same here, chokes on diminish.elc. Any luck with the issue?

jschaf commented 9 years ago

I have a hunch that the issue is forward-sexp on byte-code. I'll add some tests to see if I can narrow the issue.

manuel-uberti commented 9 years ago

Thanks.

dotmilk commented 8 years ago

Any word on this? I just ran in to it.

jschaf commented 8 years ago

Are you on the latest version? I think disabling debugging in https://github.com/jschaf/esup/commit/1b17a0f23b7044484061e5b52f246939c68181d8 might have fixed it, but I haven't tested it.

dotmilk commented 8 years ago

@jschaf 20160716.23 freshly installed same EOF on diminish

jschaf commented 8 years ago

Sorry, been busy at work. I'll see if I can narrow it down tonight.

jschaf commented 8 years ago

Pretty sure I found the bug.

(defvar ahhhhhhhhhhh "%" (#$ . 1))

My parsing logic looks like it fails on percent signs. Probably interacting weirdly with format. Should have a fix in the next few days.

jschaf commented 8 years ago

The percent sign was a red herring. It was me not skipping dynamic docstrings at the beginning of a .elc file. I can parse diminish.elc now.

Should be fixed in https://github.com/jschaf/esup/commit/4028431ad3f9d6682b9afb6888d678b56617e5f4.

Let me know if it works for you.

dotmilk commented 8 years ago

@jschaf Works wonderfully. Thank you.

jschaf commented 8 years ago

Sweet, glad it works. Only took a year and some change, but I think we're good to close this.