search

jschaf / esup

ESUP - Emacs Start Up Profiler
398 stars 22 forks source link

Refactor tests to use buttercup #76

Closed sergeyklay closed 4 years ago

sergeyklay commented 4 years ago

Presently esup use ert through ert-runner for testing purposes. However, it seems ert-runner is abandoned (the last commit a few years ago), it still uses only Emacs 24 on its own tests and in general it looks as not maintained anymore project.

It seems we need to migrate our tests to use buttercup. buttercup is available from MELPA and most recommend for general use by irc.freenode.net#emacs from 2019-2020Q1 (now current). It appears to work well with Emacs 27 pre-release and 28 e.g. build of GNU Emacs from git master.

While its semantics follow BDD and therefore impose some potentially undesired test design, this solution above all is robust and aggressively maintained. It is also depended upon by many heavily used Emacs projects such as projectile.

P.S. For questions like "Why not ERT?" see buttercup's answer.

/cc @jschaf

jschaf commented 4 years ago

Sure, I chose ert because it seemed to be the winner a few years ago. Since buttercup is actively maintained, I think it's a good choice to switch to that.

sergeyklay commented 4 years ago

@jschaf Could you please create CODECOV_TOKEN variable inside https://github.com/jschaf/esup/settings/secrets with a value from https://codecov.io/gh/jschaf/esup

I plan to enable code coverage report for each PR. So that we'll see comments like this:

image

jschaf commented 4 years ago

I added the token. Let me know if it doesn't work.

sergeyklay commented 4 years ago

Works like a charm. Thank you!