jsconfjp / jsconf.jp

Website
https://jsconf.jp
32 stars 28 forks source link

404 error page #470

Open martinheidegger opened 4 weeks ago

martinheidegger commented 4 weeks ago

Right now a link to a unspecified url shows the default github 404 page: https://jsconf.jp/anywhere It would be good to implement a custom 404 page for the jsconf site.

現在、指定されていない URL へのリンクには、デフォルトの github 404 ページが表示されます: https://jsconf.jp/anywhere jsconf サイト用にカスタム 404 ページを実装すると良いでしょう。

ansh-saini commented 3 weeks ago

Hi, I would like to work on this. Do you have anything specific in mind regarding the design of the 404 page?

ansh-saini commented 3 weeks ago

How does this look?

image
martinheidegger commented 3 weeks ago

I don't have something particular in mind but it is important to note that the website contains various generations of website and not just /2024 content

ansh-saini commented 3 weeks ago

Thanks for the heads up. Do you need a 404 page for all the years?

martinheidegger commented 3 weeks ago

Yes, for the entire site. (It is not necessary to have a different one every year)

martinheidegger commented 3 weeks ago

@ansh-saini I erroneously pointed out that its hosted on github, but its actually hosted on netlify. (sorry about this)

https://answers.netlify.com/t/custom-404-page-handling/76745

ansh-saini commented 3 weeks ago

Hey @martinheidegger I'll continue to work on this PR, but can you please add the hacktoberfest-accepted label on this PR so it can count towards my hacktoberfest contributions?