search

jsdf / react-native-refreshable-listview

Deprecated. A pull-to-refresh ListView which shows a loading spinner while your data reloads
1.38k stars 168 forks source link

Navigation Breaks Images #11

Closed soheil-zz closed 8 years ago

soheil-zz commented 9 years ago

Assuming you have a RefreshableListView as the root component. If you push components two levels deep in the navigator and pop back to root any images in the RefreshableListView no longer get updated if you change the image URL on the state.

              <Image
                source={{uri: rowData.posters.thumbnail}}
                style={styles.cellImage} />

if you change rowData.posters.thumbnail image does not update anymore.

jsdf commented 9 years ago

Does this happen with a regular ListView?

soheil-zz commented 9 years ago

Yes actually it does, I have already posted an issue to React Native repo: https://github.com/facebook/react-native/issues/1161

jsdf commented 9 years ago

Are you sure you've used the ListView rowHasChanged callback correctly? So that if rowData.posters.thumbnail changes it will return false?

soheil-zz commented 9 years ago

Yes because I can see the text in the row changing but not the image!

jsdf commented 9 years ago

Ahh okay, fair enough. If you're satisfied that it's an issue in the underlying React Native ListView then feel free to close this issue as it should be resolved by any fix made in React Native.

soheil-zz commented 9 years ago

sure let's wait for them. Thanks.

On Thu, May 7, 2015 at 6:06 PM, James Friend notifications@github.com wrote:

Ahh okay, fair enough. If you're satisfied that it's an issue in the underlying React Native ListView then feel free to close this issue as it should be resolved by any fix made in React Native.

— Reply to this email directly or view it on GitHub https://github.com/jsdf/react-native-refreshable-listview/issues/11#issuecomment-100058236 .