If the icon is unspecified, leave the label off of the marker uri such t...

jseppi / Leaflet.MakiMarkers

Leaflet plugin to create map icons using Maki Icons from Mapbox.

MIT License

141 stars 39 forks source link

If the icon is unspecified, leave the label off of the marker uri such t... #4

Closed markprotas closed 10 years ago

markprotas commented 10 years ago

...hat a colored marker will be drawn without a nested icon

jseppi commented 10 years ago

Thanks, didn't realize the marker API worked without an icon name. Just now looking at the documentation at https://www.mapbox.com/developers/api/static/#markers I see that color is now also optional.

Your change omits the use of letters (a-z) and digits (0-9) which are also allowable in addition to the icon names. I think I'll just rework the code a little to take into account the optional parameters. Thanks for the pull request!

markprotas commented 10 years ago

Good call- I didn't need alphanumerics for my use case but it makes sense to support their use.

jseppi commented 10 years ago

Null-valued icon and color options are now handled. Thanks for the input!