search

jserv / full-stack-hello

minimal instruction set and assembler/compiler for "Hello World" execution
Other
114 stars 49 forks source link

Added a few instructions for conditional execution. #20

Closed pakls closed 7 years ago

pakls commented 7 years ago

SUB is used as CMP.

mlouielu commented 7 years ago

@pakls, you don't need to rebase or squash to addressed each review changed. GitHub can squash at the end of the review when PR is accepted. (@jserv: FYI, the merged button have a squash and merged function can use)

jserv commented 7 years ago

@mlouielu , I knew there is a merge + squash button, but it is slightly difficult for me to edit messages in consistent manner.

mlouielu commented 7 years ago

@jserv, yep, that is somehow hard to use. But if using git rebase and force push to GitHub, the review comment will be a mess. You can see at the top of your three comments are collapsed and labeling as "Show outdated".

Which method do you more prefer on GitHub?

jserv commented 7 years ago

Essential code review messages should take place in conversations rather than inlined. At present, I prefer t ask contributors to squash and reorder Git commits.