search

jsfenfen / 990-xml-database

Django app to consume and store 990 data and metadata
BSD 2-Clause "Simplified" License
23 stars 16 forks source link

adjustments for building DB and using newer version of irsx #24

Open fgregg opened 5 years ago

fgregg commented 5 years ago

Hi @jsfenfen, this PR has a number of different pieces that you may or not be interested in. I can split things apart to just get you what you do care about.

jsfenfen commented 5 years ago

Thanks so much for sharing this @Forest Gregg fgregg@datamade.us, excited to take a look. in the next few days. You're reading is correct; at the outset I didn't want to require an amazon account, but the download with aws is so much better with one it probably makes sense to use it (and everyone working with this data at scale probably has one anyways).

On Wed, Jul 17, 2019 at 3:02 PM Forest Gregg notifications@github.com wrote:

Hi @jsfenfen https://github.com/jsfenfen, this PR has a number of different pieces that you may or not be interested in. I can split things apart to just get you what you do care about.

You can view, comment on, or merge this pull request online at:

https://github.com/jsfenfen/990-xml-database/pull/24 Commit Summary

  • adjustments for building DB and using newer version of irsx

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jsfenfen/990-xml-database/pull/24?email_source=notifications&email_token=AAE4AJFEEWAZBBZE6NS7F63P76JFVA5CNFSM4IEU535KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G73QODA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4AJELCDXJB5JFF7BU4PTP76JFVANCNFSM4IEU535A .

bcipolli commented 4 years ago

Would recommend splitting off the change from version_start/version_end to versions, as that will be a breaking change for existing installs. Otherwise, I think this is good to go.