search

jshackles / RetroGOG

RetroArch integrations for GOG Galaxy 2.0
92 stars 10 forks source link

Fix for 7z issue #1

Closed ChristofferGreen closed 4 years ago

ChristofferGreen commented 4 years ago

My snes playlist has entries like so: "path": "C:\Emulation\Roms\Nintendo - Super Nintendo Entertainment System\ActRaiser (USA).7z#ActRaiser (USA).sfc",

The view into the 7z file ("#ActRaiser (USA).sfc") causes issues due to python not being able to find the path. Added a fix for this.

benjamin-allion commented 4 years ago

Hi, thank's for your fix ! Please see https://github.com/jshackles/RetroGOG/pull/2 That's the same fix as the one you suggest but for all platforms.

Of course, cause i used your code, I added you as co-author on my commit.

benjamin-allion commented 4 years ago

Hope that @jshackles can validate & merge the https://github.com/jshackles/RetroGOG/pull/2 soon 🙏.

ChristofferGreen commented 4 years ago

Hi @benjamin-allion

Not sure, but @jshackles apppears to be dead. May be better to just fork the project.

jshackles commented 4 years ago

Not dead thankfully! Just went through a move where I had my dev machine packed up for the better part of a month. I merged #2 which includes this fix. Thanks both.