search

jshttp / mime-db

Media Type Database
MIT License
1.09k stars 256 forks source link

Update iana-types.json #295

Open pzsette opened 1 year ago

pzsette commented 1 year ago

Add 'dcm' extension to application/dicom mime. 'dcm' is the recommended extension for this multimedia type as stated at point 2 of additional information in this iana.org page https://www.iana.org/assignments/media-types/application/dicom.

DimitriPapadopoulos commented 1 year ago

Partial duplicate of #287. This is the correct fix, prefer it over #287.

pzsette commented 1 year ago

@DimitriPapadopoulos How long does it take to approve the pull request?

dougwilson commented 1 year ago

Sorry, I thought I already commented on it, but apparently I never submitted the comment. The PR needs to be updated to change a non generated file.

DimitriPapadopoulos commented 1 year ago

@dougwilson So #287 is the correct fix after all, with "application/dicom" split between src/iana-types.json for the part extracted as is from the IANA database, and the addition in src/custom-types.json?

Shouldn't the IANA database be fixed upstream?