search

jsjolen / smallest-java-ci

CI that we made for edu. purposes.
0 stars 0 forks source link

Feat 14 Gradle #15

Closed jsjolen closed 5 years ago

jsjolen commented 5 years ago

I have implemented Gradle communications but it's hard to test (need to set up an environment to test it in, etc.). I tried out mocking but it would've required a massive amount of work so I'm avoiding that. I then tried testing by using our project, but this obviously leads to looping when running gradle test :-).

I'll be looking into testing this tomorrow.

Fixes #14

modnikhil commented 5 years ago

Overall, source code looks good. Waiting for some sort of test cases to merge.

Toyed around with the test in this branch locally. Is the main problem stemming from the fact that the test case runs gradle build which runs the test cases causing an infinite loop? If so, is it possible to build while excluding the test cases for GradleComm.java?

jsjolen commented 5 years ago

That's exactly it! Also, probably not. I'm not sure which way works best.

jsjolen commented 5 years ago

Actually you could do something like make a file and check if the file exists or something like that. I'll look into it!

jsjolen commented 5 years ago

Aaah! @modnikhil I'm sorry, for some reason I clicked merge (I can't even remember doing that, I must have clicked the wrong button). I'll be fixing up a new issue for the tests specifically and write code for it.