jsk-ros-pkg / jsk_roseus

ROS EusLisp Client
http://wiki.ros.org/roseus/Tutorials
17 stars 56 forks source link

add github action for python check #740

Closed knorth55 closed 1 year ago

knorth55 commented 1 year ago

add python2 and python3 check as mentioned in https://github.com/jsk-ros-pkg/jsk_roseus/pull/739#issuecomment-1406368983

python3 check test may fail in this PR.

knorth55 commented 1 year ago

the build in this PR failed with the following error. I solved the issue in #739

--- ./roseus/cmake/get_all_depends.py   (original)
RefactoringTool: ./roseus/cmake/get_all_depends.py
+++ ./roseus/cmake/get_all_depends.py   (refactored)
RefactoringTool: ./roseus/test/test_geneus_send_msgs.py
@@ -48,7 +48,7 @@
     for ws in workspaces.get_spaces():
         pkgs = packages.find_packages(ws)
         for pkg in pkgs.values():
-            if not pkg_map.has_key(pkg.name):
+            if pkg.name not in pkg_map:
                 pkg_map[pkg.name] = pkg
     return pkg_map
 geneus.geneus_main.pkg_map = get_pkg_map()
Exitting with 1