search

jsm174 / vpx-standalone-scripts

Table patches for VPX Standalone
https://github.com/vpinball/vpinball/tree/standalone/
34 stars 15 forks source link

Add The Neverending Story FlexDMD #331

Closed evilwraith closed 2 weeks ago

evilwraith commented 3 weeks ago

Add FlexDMD to Cabinet Mode for The Neverending Story

Original table here:

https://vpuniverse.com/files/file/15488-neverending-story-mod/

francisdb commented 3 weeks ago

Mind renaming this pr to mention the table name?

francisdb commented 3 weeks ago

Mind adding the table url to the PR description?

francisdb commented 3 weeks ago

Can you also rename the patch file to contain dmd ?

francisdb commented 3 weeks ago

The downloaded file is Neverending Story (2021).vpx and not The Neverending Story(Original 2021) v1.vpx?

francisdb commented 3 weeks ago

image

Looks like the embedded dmd no longer shows scores?

evilwraith commented 3 weeks ago

Looks like the embedded dmd no longer shows scores?

I believe that's as intended. There's a change that can be made to the asset in vpx to fill that in. I can try to modify the script to address that but the solution is to change the asset.

evilwraith commented 3 weeks ago

Asset is Wall54, backwall_noDMD

francisdb commented 2 weeks ago

So #332 behaves the same? Found it strange that images do work.

evilwraith commented 2 weeks ago

Oh what the hell I changed that. Will fix. Again.

On Mon, Nov 4, 2024, 11:07 AM Francis De Brabandere < @.***> wrote:

@.**** commented on this pull request.

In The Neverending Story(Original 2021) v1/The Neverending Story (Original 2021).vbs.dmd.patch https://github.com/jsm174/vpx-standalone-scripts/pull/331#discussion_r1827987577 :

++ Else ++ FlexDMD.TableFile = Table1.Filename & ".vpx" ++ FlexDMD.RenderMode = 2 ++ FlexDMD.Width = 128 ++ FlexDMD.Height = 32 ++ FlexDMD.Clear = True ++ FlexDMD.GameName = cGameName ++ FlexDMD.Run = True ++ Set DMDScene = FlexDMD.NewGroup("Scene") ++ DMDScene.AddActor FlexDMD.NewImage("Back", "VPX.bkborder") ++ DMDScene.GetImage("Back").SetSize FlexDMD.Width, FlexDMD.Height ++ For i = 0 to 35 ++ DMDScene.AddActor FlexDMD.NewImage("Dig" & i, "VPX.dempty&dmd=2") ++ Digits(i).Visible = False ++ Next ++ digitgrid.Visible = False

Same fix required here?

— Reply to this email directly, view it on GitHub https://github.com/jsm174/vpx-standalone-scripts/pull/331#pullrequestreview-2413485343, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX57UK2ZCPBVGHI6WLNIXLZ66LUBAVCNFSM6AAAAABQ7FGBXWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJTGQ4DKMZUGM . You are receiving this because you authored the thread.Message ID: @.***>

francisdb commented 2 weeks ago

@jsm174 I think this is ok to go

jsm174 commented 2 weeks ago

@evilwraith - awesome!!

@francisdb - thanks for working with @evilwraith on this!!