jsmitty12 / phpWhois

phpWhois general repository
GNU General Public License v2.0
56 stars 20 forks source link

Code cleanup #33

Open tomsommer opened 6 years ago

tomsommer commented 6 years ago

The project is suffering from a really bloated codebase. It should be cleaned up.

This includes having namespaces added (to not pollute the global scope with functions) and have correct access modifiers to internal methods and variables.

jsmitty12 commented 6 years ago

I couldn't agree more and we're slowly moving towards this.

I started the process by adding some much needed tests around the TLD handlers (which is still in progress), but the end goal has always been to eliminate the PHP 4 era structure in favor a fully namespaced structure implementing today's best practices.