search

jsocolar / flocker

flexible occupancy estimation in R
Other
28 stars 3 forks source link

added functionality for running loo on a thinned object #48

Closed SimonCMills closed 2 years ago

SimonCMills commented 2 years ago

Necessary for reducing memory overhead on v. large models. loo functions have a thin argument; log_lik_V() has a draw_ids argument, which are passed from the loo functions. When you provide loo with a single model, it also returns the dimensions of the log_lik matrix it has generated them from. loo_compare_flocker doesn't, and it would be good to add this at some point (given you can now calculate over a thinned matrix).

edit: also added unit tests for loo functions and log_lik_V()

codecov-commenter commented 2 years ago

Codecov Report

Merging #48 (c0dc068) into main (1259ffa) will increase coverage by 17.33%. The diff coverage is 93.10%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #48       +/-   ##
===========================================
+ Coverage   25.83%   43.16%   +17.33%     
===========================================
  Files          11       11               
  Lines         538      549       +11     
===========================================
+ Hits          139      237       +98     
+ Misses        399      312       -87
Impacted Files Coverage Δ
R/loo.R 94.59% <89.47%> (+94.59%) :arrow_up:
R/log_lik_occupancy.R 66.66% <100.00%> (+66.66%) :arrow_up:
R/utils.R 58.62% <0.00%> (+58.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1259ffa...c0dc068. Read the comment docs.