json-editor / json-editor

JSON Schema Based Editor
MIT License
4.52k stars 667 forks source link

List of 2.x changes #450

Closed pmk65 closed 4 years ago

pmk65 commented 5 years ago

2.x changes

New Theme format (Old themes can still be used, but might not display correctly in some cases.):

Themes in 2.x format:

Refactored editors:

New Editors:

New special editors: (Does not leave any footprint in form results)

Also various minor bugs and issues have been fixed during refactoring/cleanup.

ToDo:

schmunk42 commented 5 years ago

Let's put that into the CHANGELOG in devleop/2.x

pmk65 commented 5 years ago

I have also updated several of the Playground examples and added new ones too. (So now some of the examples REQUIRE the 2.x version)

sirockin commented 5 years ago

I forked develop/2.x at commit 72fc61eca7cea08d9361f9fed34a5cff390fe152 to work on the webpack stuff. Hoping to have something for you in a few days. From what I can see of your changes since then, it shouldn't be too hard for us to merge.

sirockin commented 5 years ago

Now submitted as https://github.com/json-editor/json-editor/pull/486

sirockin commented 5 years ago

Is there a proposed timetable for merging/releasing this branch? I have some other issues I'd like to work on and I'm wondering whether it would be better to wait until then.

schmunk42 commented 5 years ago

@sirockin Issue #486 can be merged ASAP. I'd recommend to continue with develop/2.x, we had no big changes on master.

pmk65 commented 5 years ago

Generally all develop/2.x will/should be merged as soon as it has passed tests and reviews. (@schmunk42 Shouldn't we upgrade @sirockin to project collaborator?)

schmunk42 commented 5 years ago

@sirockin Would you be OK with it?

sirockin commented 5 years ago

No problem - would it confer any responsibilities? - I ask because I have big chunks of time when I'm offline so can't always be available.

pmk65 commented 5 years ago

@sirockin No. it's just easier to assign issues to you and you have the ability to review and merge PRs. BTW: I Added some text in the top of the list of 2.x changes about the Webpack. Feel free to add more or a better explanation of the changes.

schmunk42 commented 5 years ago

I've sent you invitations to the developer group.

qtiki commented 4 years ago

It seems that the latest version in npm is 2.1.0 - does that mean this issue is done?

Our project is still using the legacy jdorn/jsoneditor package so I'm thinking of switching to this one. So are all the major v2 changes done and now would be a good time to upgrade?

schmunk42 commented 4 years ago

It seems that the latest version in npm is 2.1.0 - does that mean this issue is done?

Yes, I'll close it.

Our project is still using the legacy jdorn/jsoneditor package so I'm thinking of switching to this one. So are all the major v2 changes done and now would be a good time to upgrade?

Yes, I think so.