Closed pmk65 closed 4 years ago
Let's put that into the CHANGELOG in devleop/2.x
I have also updated several of the Playground examples and added new ones too. (So now some of the examples REQUIRE the 2.x version)
I forked develop/2.x at commit 72fc61eca7cea08d9361f9fed34a5cff390fe152 to work on the webpack stuff. Hoping to have something for you in a few days. From what I can see of your changes since then, it shouldn't be too hard for us to merge.
Now submitted as https://github.com/json-editor/json-editor/pull/486
Is there a proposed timetable for merging/releasing this branch? I have some other issues I'd like to work on and I'm wondering whether it would be better to wait until then.
@sirockin Issue #486 can be merged ASAP. I'd recommend to continue with develop/2.x
, we had no big changes on master
.
Generally all develop/2.x will/should be merged as soon as it has passed tests and reviews. (@schmunk42 Shouldn't we upgrade @sirockin to project collaborator?)
@sirockin Would you be OK with it?
No problem - would it confer any responsibilities? - I ask because I have big chunks of time when I'm offline so can't always be available.
@sirockin No. it's just easier to assign issues to you and you have the ability to review and merge PRs. BTW: I Added some text in the top of the list of 2.x changes about the Webpack. Feel free to add more or a better explanation of the changes.
I've sent you invitations to the developer group.
It seems that the latest version in npm is 2.1.0 - does that mean this issue is done?
Our project is still using the legacy jdorn/jsoneditor package so I'm thinking of switching to this one. So are all the major v2 changes done and now would be a good time to upgrade?
It seems that the latest version in npm is 2.1.0 - does that mean this issue is done?
Yes, I'll close it.
Our project is still using the legacy jdorn/jsoneditor package so I'm thinking of switching to this one. So are all the major v2 changes done and now would be a good time to upgrade?
Yes, I think so.
2.x changes
release-notes.md
README_ADDON.md
)window.requestAnimationFrame
, to insure that field element have finished rendering completely. This speeds up the form rendering significantly as there is no wait for the plugin rendering to finish.window.JSONEditor.defaults.callbacks.template
)filter
,title
andvalue
can now be set to a JavaScript callback function. (Callback function is defined underwindow.JSONEditor.defaults.callbacks.template
)sort
added to dynamic "enumSource" properties. Accept values "asc" and "desc"New Theme format (Old themes can still be used, but might not display correctly in some cases.):
Themes in 2.x format:
Refactored editors:
New Editors:
New special editors: (Does not leave any footprint in form results)
Also various minor bugs and issues have been fixed during refactoring/cleanup.
ToDo:
( @lukzas )(Looking for volunteers to help updating this)