search

json-schema-org / website

JSON Schema website
https://json-schema.org
Other
67 stars 178 forks source link

fix: link-redirect-fix #1043

Closed Yashwanth1906 closed 1 month ago

Yashwanth1906 commented 1 month ago

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

This pull request addresses an issue related to incorrect URL redirection in the JSON Schema website. Users were being redirected to incorrect or unintended pages when clicking on certain links.

Changes Made:

  1. Corrected Redirecting URLs: Updated the wrong redirecting URLs in various components to ensure they point to the correct destinations. This change enhances navigation and provides users with access to the intended content.

  2. Refactored JSX Components: Adjusted the formatting of JSX components to comply with the project's style guide. Specifically, I ensured that there were proper spaces before closing brackets in the JSX tags, addressing the errors raised by the reviewers.

  3. Code Consistency: Ensured consistency in the codebase by adhering to Prettier and ESLint rules, which included correcting formatting issues to enhance code readability and maintainability.

These changes improve user experience by ensuring that links function correctly, reducing frustration caused by misdirected navigation.

Does this PR introduce a breaking change?

DhairyaMajmudar commented 1 month ago

@Yashwanth1906 run the command yarn run lint to fix the failing ci

Edit: Also please fill in the proper issue description

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview f2fff72ab59a2a491eaa6e810b995bfd87d97c51
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7ecd915) to head (f2fff72).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1043 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 373 373 Branches 94 94 ========================================= Hits 373 373 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Yashwanth1906 commented 1 month ago

All the corrections done @DhairyaMajmudar

DhairyaMajmudar commented 1 month ago

@Yashwanth1906 it seems like there were some complications with the PR since your forked repo is 11 commits behind, Pls. sync your repo, with the latest commit, create a new branch, and open a PR again.

Feel free to ask on JSON Schema slack if you face any difficulty in doing so...

Yashwanth1906 commented 1 month ago

@DhairyaMajmudar Ok I will submitting the PR soon