search

json-schema-org / website

JSON Schema website
https://json-schema.org
Other
67 stars 178 forks source link

Link-Redirect-Fix #1045

Closed Yashwanth1906 closed 1 month ago

Yashwanth1906 commented 1 month ago

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

This pull request addresses an issue related to incorrect URL redirection in the JSON Schema website. Users were being redirected to incorrect or unintended pages when clicking on certain links.

Changes Made:

  1. Corrected Redirecting URLs: Updated the wrong redirecting URLs in various components to ensure they point to the correct destinations. This change enhances navigation and provides users with access to the intended content.

  2. Refactored JSX Components: Adjusted the formatting of JSX components to comply with the project's style guide. Specifically, I ensured that there were proper spaces before closing brackets in the JSX tags, addressing the errors raised by the reviewers.

  3. Code Consistency: Ensured consistency in the codebase by adhering to Prettier and ESLint rules, which included correcting formatting issues to enhance code readability and maintainability.

These changes improve user experience by ensuring that links function correctly, reducing frustration caused by misdirected navigation.

Does this PR introduce a breaking change?

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 6e94c1f266e3d599711808334432e914b7ed31bc
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.47%. Comparing base (7ecd915) to head (6e94c1f).

Files with missing lines Patch % Lines
components/DocsHelp.tsx 77.77% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1045 +/- ## =========================================== - Coverage 100.00% 99.47% -0.53% =========================================== Files 10 10 Lines 373 380 +7 Branches 94 97 +3 =========================================== + Hits 373 378 +5 - Misses 0 2 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.