search

jsreport / jsreport-fs-store-aws-s3-persistence

Make jsreport fs store persisting entities to aws s3
5 stars 4 forks source link

Allowed to use empty AWS credentials (accessKeyId, secretAccessKey) #4

Closed antonbezpalov-flixbus closed 5 years ago

antonbezpalov-flixbus commented 5 years ago

Hi Jan,

sorry my last PR has a critical typo https://github.com/jsreport/jsreport-fs-store-aws-s3-persistence/pull/3 It must be == but not != otherwise it will throw an error for all current connections.

Can you please review this one and sorry again for my mistake.

Thank you in advance!

pofider commented 5 years ago

No problem. I missed it as well. Now fix released in 1.2.4

antonbezpalov-flixbus commented 5 years ago

Thank you for a quick response. Sorry again I hope nobody had enough time to download v1.2.3 :-)