search

jss2a98aj / NotFine

Extra video settings for Minecraft 1.7.10 implemented with Mixins
Other
33 stars 11 forks source link

Custom Colours breaks lotr biomes #34

Open mist475 opened 3 months ago

mist475 commented 3 months ago

Lotr's biome system reuses vanilla biome ids. Somewhere in the custom colours module biome ids are used or biomes are retrieved the wrong way (using the biome gen array instead of world.getBiomeGenForCoords(x,z); meaning you see the grass colours of the vanilla biome instead

jss2a98aj commented 3 months ago

I will see if I can resolve this when I rework parts of the custom color system to be threading friendly

mist475 commented 3 months ago

Having done some testing, it wasn't what I suspected. It only occurs when I run Modernity as resource pack. This means it's an inconsistency with optifine, where the lotr biome grass colours don't change incorrectly