jsverse / transloco-keys-manager

🦄 The Key to a Better Translation Experience
https://github.com/jsverse/transloco/
MIT License
203 stars 49 forks source link

Bug: find doesn't consider 'prefix' #197

Closed MikeDabrowski closed 5 months ago

MikeDabrowski commented 5 months ago

Is there an existing issue for this?

Is this a regression?

Yes

Current behavior

When running find and having the code migrated to latest transloco version, which uses prefix instead read, the find does not use those prefixes. As if it still looks for 'read' instead.

image

Expected behavior

In transloco docs it is written that read will be deprecated in v8 but since it encourages prefix I think the find should support both for the time being.

Please provide a link to a minimal reproduction of the bug

Last commit Also initial commit has its own bug

Transloco Config

No response

Debug Logs

No response

Please provide the environment you discovered this bug in

"@jsverse/transloco": "^7.4.2",
"@jsverse/transloco-locale": "^7.0.1",
"@jsverse/transloco-messageformat": "^7.0.1",
"@angular/cli": "^17.3.8",
Node: v21.0.0
Package Manager: npm
OS: windows

Additional context

No response

I would like to make a pull request for this bug

Yes 🚀

shaharkazaz commented 5 months ago

Merged 👍