jsverse / transloco-keys-manager

🦄 The Key to a Better Translation Experience
https://github.com/jsverse/transloco/
MIT License
199 stars 49 forks source link

Update dependency request: missing angular/core@17.2.0 #203

Closed MikeDabrowski closed 1 week ago

MikeDabrowski commented 1 month ago

Is there an existing issue for this?

Is this a regression?

No

Current behavior

$ time npm ci
npm error code EUSAGE
npm error
npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm error
npm error Missing: @angular/core@17.2.0 from lock file
npm error
npm error Clean install a project
npm error
npm error Usage:
npm error npm ci
npm error
npm error Options:
npm error [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]
npm error [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
npm error [--include <prod|dev|optional|peer> [--include <prod|dev|optional|peer> ...]]
npm error [--strict-peer-deps] [--foreground-scripts] [--ignore-scripts] [--no-audit]
npm error [--no-bin-links] [--no-fund] [--dry-run]
npm error [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
npm error [-ws|--workspaces] [--include-workspace-root] [--install-links]
npm error
npm error aliases: clean-install, ic, install-clean, isntall-clean
npm error
npm error Run "npm help ci" for more info
npm error A complete log of this run can be found in: /builds/pingen/pingen2ui/.npm/_logs/2024-09-15T18_07_56_4[22](https://gitlab.pingen.com/pingen/pingen2ui/-/jobs/82910#L22)Z-debug-0.log

I work primarily on Windows, sometimes use mac. When switching to mac I always had problems that marked and @angular/core: 17.2.0 were missing. I fixed marked because it was required by ngx-markdown we use. But the angular/core is more problematic. We are on Angular18 already but the transloco-key-manager requires v17. Can we get it updated?

Expected behavior

Update angular/core peer dependency to v18

Please provide a link to a minimal reproduction of the bug

Sorry, maybe later

Transloco Config

No response

Debug Logs

No response

Please provide the environment you discovered this bug in

Transloco: 
 "@jsverse/transloco": "^7.4.3",
    "@jsverse/transloco-locale": "^7.0.1",
    "@jsverse/transloco-messageformat": "^7.0.1",
Transloco Keys Manager: ^5.1.0
    "@angular-devkit/build-angular": "^18.2.3",
    "@angular-devkit/core": "^18.2.3",
    "@angular-devkit/schematics": "^18.2.3",
    "@angular-devkit/schematics-cli": "^18.2.3",
    "@angular-eslint/builder": "^18.3.0",
    "@angular-eslint/eslint-plugin": "^18.3.0",
    "@angular-eslint/eslint-plugin-template": "^18.3.0",
    "@angular-eslint/schematics": "^18.3.0",
    "@angular-eslint/template-parser": "^18.3.0",
    "@angular/compiler-cli": "^18.2.3",
    "@angular/language-service": "^18.2.3",
Node: 22.0.0
Package Manager: 10.5.1
OS: Win10 / macos

Additional context

No response

I would like to make a pull request for this bug

Yes 🚀

shaharkazaz commented 1 month ago

@MikeDabrowski I think we can change it to >=17.2 no?

shaharkazaz commented 1 week ago

@MikeDabrowski Can you try v6?

MikeDabrowski commented 1 week ago

I can confirm it works with v6. Thank you!