search

jsx-eslint / eslint-plugin-react

React-specific linting rules for ESLint
MIT License
9.01k stars 2.77k forks source link

[New] Add suggestions to `no-unescaped-entities` #3831

Closed StyleShit closed 1 month ago

StyleShit commented 1 month ago

Closes #3277

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.67%. Comparing base (59ef14c) to head (39a7a8f). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3831 +/- ## ========================================== - Coverage 97.73% 97.67% -0.06% ========================================== Files 133 136 +3 Lines 9917 9938 +21 Branches 3678 3679 +1 ========================================== + Hits 9692 9707 +15 - Misses 225 231 +6 ``` | [Flag](https://app.codecov.io/gh/jsx-eslint/eslint-plugin-react/pull/3831/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jsx-eslint) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/jsx-eslint/eslint-plugin-react/pull/3831/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jsx-eslint) | `97.67% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jsx-eslint#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ljharb commented 1 month ago

Looks pretty good, please mark ready for review once tests are passing :-)

StyleShit commented 1 month ago

@ljharb Thanks! 🙏

I have some issues running the tests locally Well, actually they run, but don't fail (as opposed to the CI), so I'm kinda writing them blindly and hoping the CI will pass 😞

Any help here would be greatly appreciated!

ljharb commented 1 month ago

You'll need to run the same commands the CI workflow is using to ensure the right versions of deps are installed; in this case i think it's that there's a lot of test cases that need to have suggestions added.

StyleShit commented 1 month ago

Oh, that makes sense. Will try it, thanks!