jtesta / ssh-audit

SSH server & client security auditing (banner, key exchange, encryption, mac, compression, compatibility, security, etc)
MIT License
3.44k stars 179 forks source link

[rfe] add tests and support for python3.12 #210

Closed NeilHanlon closed 1 year ago

NeilHanlon commented 1 year ago

Hello :)

I am working on packaging ssh-audit for Fedora and EPEL. Since Fedora has updated to python3.12, it would be great to also support 3.12, specifically in tests so they can be run when building the package.

I'm more than happy to help with this, and might take a stab at a Pull Request later, but wanted to open the issue first and introduce myself.

Best, Neil

sunwire commented 1 year ago

Hi @NeilHanlon just FYI https://copr.fedorainfracloud.org/coprs/sunwire/ssh-audit/ It seems that ssh-audit works fine on Python 3.12 If you wish, you can use this SPEC file as a starting point.

[pawel@fedora ~]$ python --version
Python 3.12.0
[pawel@fedora ~]$ cat /etc/os-release 
NAME="Fedora Linux"
VERSION="40 (Workstation Edition Prerelease)"
ID=fedora
VERSION_ID=40
VERSION_CODENAME=""
PLATFORM_ID="platform:f40"
PRETTY_NAME="Fedora Linux 40 (Workstation Edition Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:40"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
SUPPORT_END=2024-05-14
VARIANT="Workstation Edition"
VARIANT_ID=workstation
[pawel@fedora ~]$ rpm -qi ssh-audit
Name        : ssh-audit
Version     : 3.1.0
Release     : 1.git20230911.fc40
Architecture: noarch
Install Date: śro, 18 paź 2023, 17:48:41
Group       : Unspecified
Size        : 701120
License     : MIT
Signature   : RSA/SHA256, pon, 11 wrz 2023, 16:27:28, Key ID 3fffb3a61128641e
Source RPM  : ssh-audit-3.1.0-1.git20230911.fc40.src.rpm
Build Date  : pon, 11 wrz 2023, 16:27:04
Build Host  : copr-hv-x86-64-01-prod-12615745-20230911-142002
Vendor      : Fedora Copr - user sunwire
URL         : https://github.com/jtesta/ssh-audit
Summary     : ssh-audit is a tool for ssh server & client configuration auditing
Description :
ssh-audit is a tool for ssh server & client configuration auditing.
NeilHanlon commented 1 year ago

Hi @sunwire - I agree it seems to work great on python3.12, which is great news. This issue is more to track updating the tox configuration for the %check section in the RPM build.

I didn't notice your copr before, otherwise I would have used it as a base--thank you. I have a package review open here. If you're a fedora packager, I'm happy to add you as a comaintainer once it's added.

jtesta commented 1 year ago

@NeilHanlon : I just updated the Tox and Github Actions tests to include Python 3.12 support (in d62e4cd80ce581921a65e5d6795cfb3aeaf068d8). Thanks for the heads up!

NeilHanlon commented 1 year ago

Thank you!