jtesta / ssh-audit

SSH server & client security auditing (banner, key exchange, encryption, mac, compression, compatibility, security, etc)
MIT License
3.44k stars 179 forks source link

print config v2 Issue #191 #307

Open oam7575 opened 5 days ago

oam7575 commented 5 days ago

@jtesta @daniejstriata

Quotes should no longer be needed. usage : ssh-audit.py --print-config Ubuntu 2204 Server

oam7575 commented 3 days ago

Hi Joe,

As always, thanks for the review and feedback. I'll look into the changes and get back to you.

Again I will try and update and attempt to squash everything, and again if it turns into a mess - I'll close this one of and create a clean PR when the code is a bit closer to a second review.

Cheers.

jtesta commented 2 days ago

I will try and update and attempt to squash everything, and again if it turns into a mess - I'll close this one of and create a clean PR

One way to do it is to make a working branch for your next revision, add as many commits as you'd like to that, then simply make one squash merge commit back into print_guide_v2.

For example:

$ git checkout print_guide_v2  # Start with the branch that corresponds to this PR
$ git checkout -b pr307_revision_2  # Copy this branch, and use it for experimentation
$ git add [...]; git commit [...]  # Make as many commits as you'd like to this pr307_revision_2 branch
$ git checkout print_guide_v2; git merge --squash pr307_revision_2 branch  # Squash all commits from the experimental branch into one commit in print_guide_v2.

Once you push the one squashed commit in print_guide_v2, this PR will be automatically updated with that one commit. Hope this helps!