search

jtilly / matchingR

Algorithms for Matching Markets in R and C++
https://cran.r-project.org/package=matchingR
50 stars 18 forks source link

Use package microbenchmark conditionally #35

Closed njanetos closed 7 years ago

njanetos commented 7 years ago

As per Brian Ripley's direction:

'microbenchmark' is a package that does not work at all on some platforms (e.g. Sparc Solaris) and is flaky on others (e.g. my Windows laptop). And its nominal maintainer has vanished.

This makes it undesirable for packages to strictly depend on it, but packages

anMC timeit

do. Also, if it is used in Suggests: it should be used conditionally (see §1.1.3.1 of the manual), but packages

JacobiEigen R6 aoos base64url brotli checkmate cubature fourierin funrar matchingR mkin rtrie rucrdtw schumaker storr tibble wrswoR

do not do so.

Please update your package(s).

jtilly commented 7 years ago

I'm sort of okay with not supporting Solaris and windows laptops.

On May 5, 2017 2:28 PM, "Nick Janetos" notifications@github.com wrote:

Assigned #35 https://github.com/jtilly/matchingR/issues/35 to @jtilly https://github.com/jtilly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jtilly/matchingR/issues/35#event-1070478276, or mute the thread https://github.com/notifications/unsubscribe-auth/AGfe68rDDf9O0M-qSBux7G9OymhHrF5aks5r2xYAgaJpZM4NR2fN .

jtilly commented 7 years ago

Include the package conditionally or don't use it unconditionally. I opted for the latter.