search

jtsage / jtsage-datebox

A multi-mode date and time picker for Bootstrap (3&4), jQueryMobile, Foundation, Bulma, FomanticUI, and UIKit (or others)
http://datebox.jtsage.dev/
Other
474 stars 166 forks source link

Calbox - selected date is not highlighted when switching to next month, but highlighted when switching to previous month. #425

Closed slavap closed 5 years ago

slavap commented 6 years ago

April to May (bug):

image image

June to May (ok):

image image

jtsage commented 6 years ago

eww. wierd. looking at this.

jtsage commented 6 years ago

Huh. This looks like you were on the main page of the documentation site. Just tried this, and I don't see it happening.

So, I either fixed it (which I doubt, as I've done nothing).

Or, it's something browser related (maybe). Local date based (maybe).

I dunno. Any help would be cool - OS / Browser / etc.

slavap commented 6 years ago

@jtsage It was not browser or locale related, I had tested it in Chrome and Firefox, and my locale is en_US. I cannot reproduce it on http://dev.jtsage.com/DateBox/ anymore, so probably it's fixed collaterally :-) I will try to update my project from 4.3.1 to the latest version, and let you know if the problem still exists.

jtsage commented 6 years ago

Cool. thanks for taking the time.

My fear is that it relates back to a the DST bug, which I kinda knew likely existed, and would crop up in odd ways - although the test dates shouldn't be affected.

At any rate, not much to do until I / we can figure out how to get it to crop up again.

Thanks!

jtsage commented 5 years ago

This should be totally fixed in v5. I redid the theme calculations in a sane manner, rather than bolting them on way later.

jtsage commented 5 years ago

Yeah, lies, this was an outlier condition that I didn't handle in v5 yet. It's absolutely fixed now., along with an option called "calSelectedOutOfBounds", defaulted to true, which means it will use the selected theme on out of bounds dates.