search

juba / robservable

Observable notebooks as R htmlwidgets
https://juba.github.io/robservable/
163 stars 11 forks source link

Proofread the README #34

Closed juba closed 4 years ago

juba commented 4 years ago

@timelyportfolio Would you be ok, when you have time, to proofread the README file ? It has been very useful for the vignettes, and I wouldn't want potential users to stumble upon a big spelling mistake :)

Maybe after this we would not be far from a CRAN release ?

timelyportfolio commented 4 years ago

Very lightly proofread readme.md and made minor corrections. Yes, I agree we are close to CRAN. Would you be able to test on winbuilder and rhub? If not I am happy to do.

juba commented 4 years ago

Thanks for the README fixes. I tend to rely on Github actions check results, but if you want to submit to winbuilder and r-hub, it would be fine and may avoid problems when submitting.

juba commented 4 years ago

I had some time this morning, and I submitted the package to both r-hub and win-builder, as you suggested. The result was clean except for a quick fix in the Description field.

Do you think I could start pushing the package to CRAN ?

timelyportfolio commented 4 years ago

@juba In my experience winbuilder is the strictest, so if it passed there, I would say robservable is ready for a CRAN submission.

juba commented 4 years ago

Yes, I think you're right, win-builder made me a note about a possible misspelled word in DESCRIPTION that I didn't have with the other checks (I think).

Well, I'll close this issue, and let's go to CRAN then... :)