judithabk6 / med_bench

BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Exacteness tests and CI improvements (#73 and #74) #78

Closed brash6 closed 2 months ago

brash6 commented 3 months ago

This PR is the combinaison of the following PRs :

This is at the same time a great test of the new CI pipeline as it is supposed to be launched every time a new PR is created on the main branch.

If any change has to be done, I suggest to :

bthirion commented 3 months ago

What is the reason for the CI failure ?

brash6 commented 3 months ago

What is the reason for the CI failure ?

One of the reason is I think because of the fact that there's an infinitesimal difference between the obtained results and the expected results so I have to increase the tolerance threshold of the pytest.approx function.

I am going to open a new PR with CI active for develop branch so that we can test everything in this new PR before reviewing that everything is working for the main branch in this actual PR

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.00000% with 21 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@4ebee9c). Click here to learn what that means.

Files Patch % Lines
src/med_bench/get_estimation.py 58.33% 10 Missing :warning:
src/med_bench/utils/utils.py 77.77% 10 Missing :warning:
src/med_bench/mediation.py 97.29% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ======================================= Coverage ? 86.53% ======================================= Files ? 6 Lines ? 750 Branches ? 0 ======================================= Hits ? 649 Misses ? 101 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brash6 commented 2 months ago

I think we can merge this PR @bthirion @judithabk6 @houssamzenati @zbakhm