juga0 / dhcpcanon

DHCP client disclosing less identifying information.
https://dhcpap.tech
MIT License
61 stars 11 forks source link

Python 2 Support #30

Open FlorianSteenbuck opened 5 years ago

FlorianSteenbuck commented 5 years ago

This project in the early stages supports python 2. Now their is no python 2 support anyway. This is caused by two bugs that simply got ignored and not solved.

#21 Is a bug that appears because a int parsing do not work correctly. load_entry_point can not be found in source code anymore their is not reason for switch the version for a trivial error like this.

#15 Is a bug that using a python3 parameter to the function open this have something todo with encoding and can be used in python2 too

I basically miss the cool looking version badges in the README

juga0 commented 5 years ago

Hi Florian,

This project in the early stages supports python 2. Now their is no python 2 support anyway. This is caused by two bugs that simply got ignored and not solved.

They were not ignored, they were both closed as wontfix, commenting "I'm removing support for python 2"

The reasons to don't support python 2 being:

Feel free to open a PR if you have patches that would fix python 2 support.

I basically miss the cool looking version badges in the README

If you mean that they images are not currently being displayed, that's a minor format issue that should have other issue.

Is your feedback or your comments answered?.

Thanks.