search

juhp / fbrnch

Tool to update fedora packages branches
https://hackage.haskell.org/package/fbrnch
GNU General Public License v2.0
23 stars 3 forks source link

Creates update even on build failure #9

Closed QuLogic closed 3 years ago

QuLogic commented 4 years ago

Running fbrnch build -b f32 -m and eventually I got:

2020-08-08 13:15:27,829 [ERROR] koji: ReadTimeout: HTTPSConnectionPool(host='koji.fedoraproject.org', port=443): Read timed out. (read timeout=43200)

but instead of re-trying or failing, it prompted for an update message and tried to create a Bodhi update. (Everything seems down now, so it seems to have not done anything.)

juhp commented 4 years ago

I think the real solution here is probably to stop using the python koji client.

Though supposedly this was fixed.

Having said all that, I do try to workaround this by catching failure and restarting watch-task but occasionally it seems to stop completely like this. I wonder if koji could be exiting with status 0 somehow when this happens?? I need to investigate more to get to the bottom of it, but it is hard since it is quite rare.

juhp commented 4 years ago

I am going to try a change where I ignore the koji exit code and check the taskstate directly always. I hope this will improve the situation - if it is really a koji bug we should report it upstream.

juhp commented 4 years ago

I hope this change might prevent this problem from occurring.

fbrnch-0.4-1 is built now in Copr.