search

julesfern / spahql

A query language for Javascript data. Extracted from Spah.
MIT License
325 stars 20 forks source link

destroy boolean element #24

Open dzuluagaapigee opened 10 years ago

dzuluagaapigee commented 10 years ago

Hello,

Thanks for this library. It's great! Am I missing anything? Thanks! I found an issue removing nested boolean elements. For example:

var field = {"field" : {
                                  "field2" : false
                              }
                 }
var db2 = SpahQL.db(field);
db2.select('//field2').destroyAll();
db2.select('//field2') //still exists!
julesfern commented 10 years ago

Yep, that looks like a bug! Thank you for reporting it. I'll take a look when time allows - if you have an urgent need for a fix, feel free to jump in and send a pull request :)

Bohtvaroh commented 10 years ago

danski, do you really accept pool requests? Looks like this one https://github.com/danski/spahql/pull/12 isn't merged since a year of being sent.

julesfern commented 10 years ago

@Bohtvaroh thanks for pointing that out to me - I should have closed that long ago, as it isn't quite functional. I've posted an apology to the original author as I dropped the ball regardless.