search

julia-actions / cache

A shortcut action to cache Julia artifacts, packages, and registries.
MIT License
38 stars 8 forks source link

Save cache even if failures #79

Open IanButterworth opened 9 months ago

IanButterworth commented 9 months ago

I think it makes sense to cache the depot even if there have been test failures.

Unfortunately it requires an upstream change https://github.com/actions/cache/pull/1242

omus commented 7 months ago

Alternatively, if we're willing to switch away from using a composite action we can use runs.post to perform the cache save (unfortunately, this is basically re-implementing actions/cache). It's rather unfortunate composite actions don't support the pre/post steps.

IanButterworth commented 7 months ago

https://github.com/actions/cache/pull/1242 has been merged and should be out in the next release

omus commented 7 months ago

It's out in the v4 release: https://github.com/actions/cache#v4

IanButterworth commented 7 months ago

Great. I don't immediately see why it warranted a major release..