search

julia-actions / cache

A shortcut action to cache Julia artifacts, packages, and registries.
MIT License
38 stars 8 forks source link

Add option for user specified Julia depot #83

Closed omus closed 7 months ago

omus commented 7 months ago

Alternative to #74

IanButterworth commented 7 months ago

I don't think this does the same thing as #74. That PR allows inclusion of a custom depot subdir.

IanButterworth commented 7 months ago

It'd be good to have this field-tested before merge, if you happen to have such a setup

omus commented 7 months ago

I've tested this against a private with multiple steps using separate Julia depots and things work as expected. I've decided to rename the input from user-depot to just depot as the Julia depot reference by this action may not be the user depot.

One issue I've identified is that if you do use this action multiple times the default cache key will be the same for both of them as we don't include the depot input in the cache key at the moment. I'll add that in here yet but I've also identified a separate issue with the cache key which I'll file an issue for.

omus commented 7 months ago

PR is ready for review

omus commented 7 months ago

I'll also look into using JULIA_DEPOT_PATH for the default value.

omus commented 7 months ago

Validated the latest change against a private GitHub actions workflow.

IanButterworth commented 7 months ago

Given tests here don't test the default depot path, did your CI tests check that? Just want to make sure that chars like ~ are ok in artifact names

IanButterworth commented 7 months ago

I checked and it worked with default settings on another repo