search

julianlam / nodebb-plugin-sso-twitter

NodeBB Plugin that allows users to login/register via their Twitter account.
BSD 2-Clause "Simplified" License
9 stars 8 forks source link

Users unable to confirm their email addresses #13

Open henrywright opened 8 years ago

henrywright commented 8 years ago

The plugin asks users to verify their email address after registration but no email is sent out. Looking at the member's profile I can see their email is "undefined".

julianlam commented 8 years ago

Thanks, this might be a core issue as Twitter wouldn't be the only SSO plugin that would register users without emails.

I'll look into this.

henrywright commented 8 years ago

I'm not entirely sure if Twitter will give out user's email addresses via their API. Perhaps that's why we're seeing the "undefined' value?

julianlam commented 8 years ago

For sure they do not. Unless something has changed in recent years.

henrywright commented 8 years ago

Right. In that case, there is an alert that pops up asking a new user to "click here" to confirm their email. After "clicking here" the user is told the email has been sent. In fact it hasn't because there's no email address to send to.

Perhaps the solution is to ask the user to provide their email address before anything else is done?

julianlam commented 8 years ago

In core, we should just not bother with that alert.

If you use Twitter login solely, you should turn off the option that restricts posting to validated users.

henrywright commented 8 years ago

If you use Twitter login solely, you should turn off the option that restricts posting to validated users.

OK that makes sense but my problem is I allow email registration too. Turning off email validation worries me :(

julianlam commented 8 years ago

Instructing users to add their email is an acceptable workaround... I'll do that.

On Thu, 13 Aug 2015 10:38 Henry Wright notifications@github.com wrote:

If you use Twitter login solely, you should turn off the option that restricts posting to validated users.

OK that makes sense but my problem is I allow email registration too. Turning off email validation worries me :(

— Reply to this email directly or view it on GitHub https://github.com/julianlam/nodebb-plugin-sso-twitter/issues/13#issuecomment-130704144 .

Fastidious commented 8 years ago

I am having the same problem. With the Google SSO, there is an option not to require email verification, perhaps this could be implemented here? I am noticing that Google and Twitter SSO bypass "Admin Approval" on Authentication. Problem too?

Giggiux commented 7 years ago

Can you implement the "not require email verification" here too? (If possible also on Steam)

Thanks!

Edit: Check #22