julie-forman-kay-lab / IDPConformerGenerator

Build conformational representations of Intrinsically Disordered Proteins and Regions by a guided sampling of the protein torsion space
https://idpconformergenerator.readthedocs.io/
Apache License 2.0
19 stars 6 forks source link

EDSSMat50 Substitution Matrix Shortcuts #186

Closed joaomcteixeira closed 2 years ago

joaomcteixeira commented 2 years ago

This is a API break because I changed -usubs to -urestol. I dislike the word substitutions.

joaomcteixeira commented 2 years ago

Does everything seems good?

menoliu commented 2 years ago

Yes! @joaomcteixeira tested with -urestol and various -edss50 combinations, as well as without tolerances.

joaomcteixeira commented 2 years ago

All local tests are passing: tox -e docs,build,test.

Do you agree merging @menoliu ? I will do the merge to increase the version number.It has to go minor.

menoliu commented 2 years ago

Perfect, it's working on my side too from this afternoon. Let's merge @joaomcteixeira