juliussneezer04 / pe

0 stars 0 forks source link

Negative INDEXes show incorrect error message #11

Open juliussneezer04 opened 2 years ago

juliussneezer04 commented 2 years ago

Steps to reproduce:

Delete Student from Index that is negative

Expected:

Actual:

Observed in showMedical as well:

nus-pe-bot commented 2 years ago

Team's Response

We consider negative indices an invalid command format. As mentioned in the UG, the index must be a positive integer. Whereas deleteStudent 99 is technically a correct command format, just that the index is out of bounds.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

[x] I disagree

Reason for disagreement: # Reason:

While you may have mentioned to use a positive index, giving the generic error message of 'invalid command format' will confuse users who are trying to find the mistake in their command. If not an invalid index error, you may send an error about using negative indexes specifically.