IdDNSServer incorrect closing end tag placement in TIdDNS_ProcessThread.CompleteQuery

[GoogleCodeExporter]

Versions: Indy 10.6.0 (all, including current: r5087)

FILE: IdDNSServer.pas
1. Fixed "TIdDNS_ProcessThread.CompleteQuery()" - incorrect "end" tag placement.
(Closes whole "if IsMyDomains then begin" instead of just "if (QType in 
[TypeCode_A, TypeCode_AAAA]) and (Length(Answer) = 0) then begin" block)

FILE: IdDNSResolver.pas
2. Fixed "TIdDNSResolver.Resolve()" incorrectly always calling 
"ClearInternalQuery" even when processing internal query (from 
"TIdDNS_UDPServer.ExternalSearch()")

= When this and IdBytes fix ( 
http://code.google.com/p/indyproject/issues/detail?id=277 ) is applied = 
IdDNSServer can sucessfully be used as Secondary DNS Server.

------------------------
Use attached .patch files to apply mentioned fixes:
(on Windows - use GNUWin Tools: 
http://sourceforge.net/projects/gnuwin32/files/patch/ )

# Test only (While in \Indy10\Lib\Protocols\ folder)
patch --dry-run --verbose -u -i IdDNSResolver_Resolve.patch
patch --dry-run --verbose -u -i IdDNSServer_Resolve.patch

# Patch
patch --verbose -u -i IdDNSResolver_Resolve.patch
patch --verbose -u -i IdDNSServer_Resolve.patch

------------------------
(Optional) Whole "function TIdDNS_UDPServer.CompleteQuery()" probably should be 
removed, since never used and actual handling is done by "function 
TIdDNS_ProcessThread.CompleteQuery()"

Original issue reported on code.google.com by megamurm...@gmail.com on 18 Feb 2014 at 4:40

Attachments:

• IdDNSServer_Resolve.patch
• IdDNSResolver_Resolve.patch

[GoogleCodeExporter]

The patches attached to this ticket have been checked in as rev5111.  The 
TIdBytes patches for http://code.google.com/p/indyproject/issues/detail?id=277 
have not been checked in yet.

Original comment by gambit47 on 15 Mar 2014 at 6:00

• Changed state: Fixed
• Added labels: class-TIdDNSResolver, class-TIdDNSServer

[GoogleCodeExporter]

The patches for http://code.google.com/p/indyproject/issues/detail?id=277 have 
been checked in as rev5112 now.

Original comment by gambit47 on 15 Mar 2014 at 6:18