jump-sdk / jetpack_compose_country_code_picker_emoji

Jetpack Compose Country Code Picker with Emoji Flags
https://jitpack.io/#jump-sdk/jetpack_compose_country_code_picker_emoji
Apache License 2.0
45 stars 13 forks source link

Feat/text style customization #29

Closed itstanany closed 9 months ago

itstanany commented 9 months ago
hbmartin commented 9 months ago

Thanks for this @tanany365 ! And thanks for breaking up these PRs it makes reviews much easier 😄

A few notes/questions:

  1. Does this potentially conflict with colors?
  2. Would ie be useful to pass this style into the search field into SearchTextField?
  3. This now has conflicts after merging one of your other PRs
itstanany commented 9 months ago

Hello @hbmartin A potential usecase is changing font size, weight, family and other non-color related props of the text field. TBH, in my own code base I used it to increase font size of the phone number field because it was too small for my potential user

  1. Does this potentially conflict with colors?
    • Partially yes, TextStyle affects text color, but only limited to the input text value, on the other hand, colors affects , according to documentation, color of the text and content (including label, placeholder, leading and trailing icons, border)

Actually TextStyle.color always takes presedence over color property, but in case the property color is defined only and no color property is set in TextStyle, the standalone property color will take presedence.




  1. Would it be useful to pass this style into the search field into SearchTextField?

Yes, I think so,




  1. conflicts with other files in my other PRs?

Yes, becasue they all originate from the main brnach and there are some inter secting files like README, so I resolve conflicts of each PR separately after merging the previous ones.

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication