search

jupyter-book / myst-theme

Packages for creating MyST websites themes using React and Remix
https://jupyter-book.github.io/myst-theme/?path=/docs/components-introduction--docs
MIT License
17 stars 15 forks source link

➖ Hide scrollbar in PrimarySidebar #502

Closed jnywong closed 4 days ago

jnywong commented 5 days ago

Ref https://github.com/jupyter-book/mystmd/issues/1672

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: 2624fe228ccff7b8b6dcd25b118ba1a74865709c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

agoose77 commented 5 days ago

Thanks for this PR @jnywong!

I need to do some due diligence to think through what the a11y ramifications of making this change will be. I'll circle back round once I know more!

jnywong commented 5 days ago

Good shout regarding a11y principles! Happy to help with thinking around that.

jnywong commented 4 days ago

Okay yeah, this change is not very a11y-friendly!

Happy to repurpose this into making the scrollbar theme change when switching to dark mode, but need some pointers on where to start because the light/dark mode theme switcher looks a little more complicated to contribute to at first glance.