search

jupyter-book / mystmd

Command line tools for working with MyST Markdown.
https://mystmd.org/guide
MIT License
219 stars 65 forks source link

🧹 Clean up `nodeenv` and add CI tests #1561

Closed agoose77 closed 1 month ago

agoose77 commented 1 month ago

In some recent refactoring work, the nodeenv integration added some duplicate code. This PR removes that, and ensures that we're testing its usage.

I couldn't find an elegant way to create an environment without Node.js without using Docker. There's also Nix, but I know that it is not something people are familiar with. Although I am confident it would be simple to understand, if it goes wrong, things get hard.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: ee57c9a57514d82d9dc6cb1c57b03c73c79e2e25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rowanc1 commented 1 month ago

Feel free to take this over the line whenever you feel like it @agoose77!