search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 220 forks source link

Add Karpenter do-not-evict annotations to kernel-pod #1302

Closed stdmje closed 1 year ago

stdmje commented 1 year ago

Problem

Hi, while deploying new kernels that requires Karpenter to provision new nodes in order to accomodate new kernel pods i found that in certain situations those pods are being evicted. I was able to solve that using Karpenter annotation to not evict the pods.

Proposed Solution

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

kevin-bates commented 1 year ago

Hi @stdmje - thank you for opening this issue.

Karpenter appears to be a software package that makes Kubernetes provisioning easier. While it sounds great, the idea behind the templates EG provides, including kernel-pod.yaml.j2, is that they serve as examples that are meant to be customized to specific environments. Since Karpenter is not core to Kubernetes, I don't think it makes sense to include Karpenter-specific annotations in the example templates we provide. As a result, I'm going to close this issue. If others feel this change is warranted in EG's base offering, let's have that discussion (on this issue), and we can re-open this based on that outcome.