Open kloczek opened 1 year ago
Here is the pytest summary output:
And here it is full log python-jupyter-server.txt
Looks like in 2.6.0 has been made some progress and now much less (only 11) are failing Here is pytest output:
Just FTR 2.7.0 pytest output:
four new units started failing in 2.7.2 Here is pytest output:
I'm getting the same error. I found some info, FYI.
delete_to_trash
will cause Invalid cross-device link
error, This is because send2trash thinks it's bad to move files across devices: https://github.com/arsenetar/send2trash/issues/26
And we seem to know it exists: https://github.com/jupyter-server/jupyter_server/blob/main/tests/services/contents/test_manager.py#L735
Should we mark those tests as xfail? Or I'm wondering if we should allow cross-device moves to trash while adding a feature like "this file is too large and will be deleted instead of moved to the trash". @blink1073
The tests pass in our CI on multiple platforms, we can accept PRs to make it work with downstream repackagers, but we don't have the bandwidth ourselves.
Sounds reasonable. I'm going to put it on hold for now because I haven't come up with anything good. 👀
The tests pass in our CI on multiple platforms, we can accept PRs to make it work with downstream repackagers, but we don't have the bandwidth ourselves.
To form PR you must know first what is going on in the actual code. I'm only messenger ..
Any pdate? 🤔
Just tested 2.14.1
After add to --deselect all above failing units pytest with every next iteration still fails with growing list of failing units.
I'm packaging your module as an rpm package so I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modulescut off from access to the public network
(pytest is executed with-m "not network"
)I had much more failing units however today I found that I had few missing modules in buuld env. I'm assuming that still something is missing in build env of that mdule however I have difficulty now with finding what exactly still is missing. May I ask for some help/hints? 🤔
Here is list of installed modules in build env