search

jupyter-widgets-contrib / ipygany

3-D Scientific Visualization in the Jupyter Notebook
BSD 3-Clause "New" or "Revised" License
487 stars 53 forks source link

Support Point Cloud #103

Open akaszynski opened 3 years ago

akaszynski commented 3 years ago

Looking at pythreejs, it seems like it should be possible to add a point cloud. Any hints for getting this added? I'm fine with submitting a PR.

akaszynski commented 3 years ago

My bad, it's in ipygany, just not documented: https://github.com/QuantStack/ipygany/blob/9181b7d5408ee0304f50ae3fd22beab45076224a/ipygany/ipygany.py#L426-L433

Would be nice to have docs and a from_pyvista method. Mind if I leave this open to remind myself?

akaszynski commented 3 years ago

Almost there. Is there any way to change the size of the points?

pc

martinRenou commented 3 years ago

Thanks for opening an issue!

Almost there. Is there any way to change the size of the points?

Unfortunately not yet. There are some limitations in the ThreeJS Materials I am using in ipygany (see https://github.com/mrdoob/three.js/issues/18153). I will try to allocate some time this week for this and other ipygany stuffs and release it :)

akaszynski commented 3 years ago

I'm working on supporting ipygany in https://github.com/pyvista/pyvista/pull/1239, and adding features like point sizes and wireframes would be really helpful. I realize that much needs to be added under the hood to support this, but I'd really like to be able to mirror many of the features available in vtk.js to ipygany since threejs is a bit more performant. A few features would be super valuable like:

Please let me know if I can help out.

deeplook commented 2 years ago

Any update on this?

akaszynski commented 2 years ago

Note that pyvista now supports using pythreejs: https://docs.pyvista.org/user-guide/jupyter/pythreejs.html

You can use a ton of features that are unavailable in ipygany.

deeplook commented 2 years ago

Correct, I'm using it already. 😉