Add try catches to tmp dir cleanup in xinterpreter.cpp

jupyter-xeus / xeus-robot

Jupyter kernel for Robot Framework

BSD 3-Clause "New" or "Revised" License

31 stars 11 forks source link

Add try catches to tmp dir cleanup in xinterpreter.cpp #90

Closed xylix closed 2 years ago

xylix commented 2 years ago

This is just a draft because we weren't sure what logging to use for the errors / warnings.

But currently if the tmpdir is file locked (sometimes happens on windows), errors on removing the directory can stop execution, which is most likely not desirable. Comments welcome.

(If a proper repro of the bug is needed I can try to create one.)

martinRenou commented 2 years ago

Kicking CI

martinRenou commented 2 years ago

It's jupyter-kernel-test being annoying. Let's merge. Thanks!