search

jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling
https://jupytercad.github.io/JupyterCAD
BSD 3-Clause "New" or "Revised" License
141 stars 18 forks source link

Some clip plane improvements #503

Closed martinRenou closed 1 month ago

martinRenou commented 1 month ago

Explore fixing #500 + explore fixing z-fighting using polygon offset.

I can't seem to implement the later using the logarithmic depth buffer, so opening as draft for now.

https://github.com/user-attachments/assets/aef66c27-0bec-4e5c-b275-ce086f6552cf

github-actions[bot] commented 1 month ago

Integration tests repot: appsharing.space

github-actions[bot] commented 1 month ago

Preview PR at appsharing.space

SylvainCorlay commented 1 month ago

Maybe the simpler color theme fix could be merged independently first.

martinRenou commented 1 month ago

This may be a bit more involved as this will require hacking around the fragment shader to manually offset the depth computation after the logarithmic depth buffer was performed. See #509

SylvainCorlay commented 1 month ago

I think that the clip plane remains a case in which solving the z fighting issue makes a lot of sense.

martinRenou commented 1 month ago

Definitely

martinRenou commented 1 month ago

Replaced by https://github.com/jupytercad/JupyterCAD/pull/539