jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling
https://jupytercad.github.io/JupyterCAD
BSD 3-Clause "New" or "Revised" License
141 stars 18 forks source link

Add Translation Controls #529

Closed arjxn-py closed 3 weeks ago

arjxn-py commented 1 month ago

https://github.com/user-attachments/assets/2ce1827d-8186-4e03-99ae-3e10a8fcf80d

Shall partially supersede #151

github-actions[bot] commented 1 month ago

Preview PR at appsharing.space

github-actions[bot] commented 1 month ago

Integration tests repot: appsharing.space

github-actions[bot] commented 3 weeks ago

Integration tests report: appsharing.space

martinRenou commented 3 weeks ago

After some testing I think this is looking and working great.

Just one open question, do we want the transform control to be enabled for hidden objects? Happy to get your thoughts @arjxn-py @trungleduc @SylvainCorlay

Allowing this allows that workflow:

https://github.com/user-attachments/assets/f2e891d4-a8a6-47d9-bbd3-2682dcc64b1f

arjxn-py commented 3 weeks ago

Just one open question, do we want the transform control to be enabled for hidden objects?

My first response to that would have been "No" but after looking at the workflow you've shared it looks like nice to have

trungleduc commented 3 weeks ago

we might want to have an intermediate state for selected hidden object by playing with object's opacity.

SylvainCorlay commented 3 weeks ago

Just one open question, do we want the transform control to be enabled for hidden objects?

My first response to that would have been "No" but after looking at the workflow you've shared it looks like nice to have

Same here. I saw it and though "cool!".

martinRenou commented 3 weeks ago

we might want to have an intermediate state for selected hidden object by playing with object's opacity

I love it.

Though transparency can be tricky, but if it's just one object at a time that should be fine.

arjxn-py commented 3 weeks ago

we might want to have an intermediate state for selected hidden object by playing with object's opacity.

Just this remaining, if i'm not forgetting anything (for translation)

SylvainCorlay commented 3 weeks ago

Just this remaining, if i'm not forgetting anything (for translation)

This could be a separate PR.