STL and STEP file icons

[SylvainCorlay]

It seems that the file icon is not showing up in the tab title for STL and STEP files.

On a separate note, it would probably make sense to not use the JupyterCAD logo for these file types, but use a different one for each.

[trungleduc]

https://www.flaticon.com/free-icon/stl_9811308?term=stl+file&page=1&position=10&origin=search&related_id=9811308 https://www.flaticon.com/free-icon/stp_9811307?term=stp+file&page=1&position=3&origin=search&related_id=9811307

These icons look good

[SylvainCorlay]

Yes, we could have something like this, but reusing the current file icon of JupyterLab for consistency.

[o314]

Here they are :

[martinRenou]

Nice, thanks @o314! Did you make those yourself?

Only comment: the round corners are not the same for the underlying file icon and the filename label:

Otherwise it looks great!

[o314]

Hello,

Yes i have done them by myself I use the original file in the jupyter repo for the back @ https://github.com/jupyterlab/jupyterlab/blob/main/packages/ui-components/style/icons/filetype/file.svg and recreate the overlay from your link.

Here are the patched ones from your remarks

PS: they are very big, something from github. download them to see them opening in a new tab directly from gh leads to a leak

[SylvainCorlay]

@o314 @martinRenou thank you for your work on the icon.

I have a comment on the design: I think that it would look better with a sans-serif font for STL and STP.

[o314]

OK. The font was not the good one since i have not found any probing setup in jupyter repo. Of course, this has to be reworked - however this proto font was already sans serif.

Here is a file with variations on the font ; the formers are more cad oriented ; the later more commons. If you 've got a jupyter specific one. point it up, i will brush up the icons

Last line is a more comprehensive rework, i finally prefer. The current design tends to be overwhelmed with details . So i merge all backs layers into a unique sheet, common in cad To reinforce the cad environment again, i've added a symbol that can be either understood as a drawing board or as a crane, so it encompasses the whole lifecycle of cad. The back layer is similar to the jupyter commons (same stroke, stroke width, dims) but not exactly due to the merge of back layers.

jupytercad icons, curved.pdf

The display is a rasterized shot, the file is a vectorized one. The design file is not svg. Tell me what is your choice, i will provide u the corresponding svg file.

the jupyter base icon was

PS: edited, add a second variant for new design (w/wo rhombus, eg. an icon for specialized cad) PPS: recall the jupyter base icon for an easy comp

[arjxn-py]

Super duper @o314, these looks awesome. I like almost all of them. Hence don't have a strong opinion on any single design, tho i think the below two rows are not going to align well with the minimal design :)

I'll leave it up on others to choose any one. So Good :)

[martinRenou]

Thanks a lot @o314 that's very much appreciated! Same opinion as @arjxn-py on this, they all look good and I also believe the last two rows don't match the rest of the JupyterLab design.

[SylvainCorlay]

I agree with @martinRenou that the onces matchings the JupyterLab design would be a better choice. Regarding the choice of font, I would go for a thick one because the thin versions may not be very readable at small sizes.

[o314]

ok. the 3rd and 4th columns are the declension for the bold font of the same family when available. fwi fira is the font that comes from mozilla for firefox (it should match a large public)

[SylvainCorlay]

fira is the font that comes from mozilla for firefox (it should match a large public)

Great. I think it would make sense for included svg to simply have the caption converted to path, so that it does not depend on a font.

[martinRenou]

@o314 do you have an svg version of your icons handy?

[o314]

Here are the ones that have been vectorized from fira mono bold

[martinRenou]

This is fixed! Thanks @o314 for the icons, you've been credited for this :)

[o314]

You're welcome ! Thanks for your work and kind words too In english, from Lyon