jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling
https://jupytercad.github.io/JupyterCAD
BSD 3-Clause "New" or "Revised" License
141 stars 18 forks source link

Perform a dry run for transforms #575

Closed martinRenou closed 3 weeks ago

martinRenou commented 3 weeks ago

Fix https://github.com/jupytercad/JupyterCAD/issues/572

This prevents a critical crash when the translation transform cannot be applied, by not applying the transform.

https://github.com/user-attachments/assets/bd61e19c-a969-4ba1-af48-cbe85489866d

martinRenou commented 3 weeks ago

@trungleduc on the long term, I guess we will want to move the dry run logic (hence the worker) higher in the stack instead of in the main view model.

That way the object properties panel does not depend on a main view model being around?

trungleduc commented 3 weeks ago

@trungleduc on the long term, I guess we will want to move the dry run logic (hence the worker) higher in the stack instead of in the main view model.

That way the object properties panel does not depend on a main view model being around?

Indeed, the main view is doing too much thing

github-actions[bot] commented 3 weeks ago

Integration tests report: appsharing.space

github-actions[bot] commented 3 weeks ago

Preview PR at appsharing.space